HsiangKai updated this revision to Diff 336345.
HsiangKai added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99593/new/
https://reviews.llvm.org/D99593
Files:
clang/include/clang/Basic/riscv_vector.td
clang/lib/AS
khchen added inline comments.
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:594
auto PType = Transformer.back();
+ static unsigned NFCount = 0;
switch (PType) {
rogfer01 wrote:
> Was this meant to be `static` here?
Maybe we can create a new complex ty
rogfer01 added a comment.
This is just a suggestion, feel free to ignore: a sequence of `T`s was easy to
parse for the prototype but may be want to consider something like `T3v` rather
than `TTTv`. I think it would simplify the `TString` tblgen class and those
`std::string(N, 'T')`.
HsiangKai created this revision.
HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01.
Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques,
apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,
brucehoult, MartinMosbeck, edward-jones, zzhe
