[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

thakis added a comment. Thanks, that bot is happy again. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported)

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlock

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal marked 2 inline comments as done. steakhal added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlock

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

thakis added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported) { steakhal

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported) { thakis

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

thakis added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported) { Does this

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG936d1e97a32d: [ASTImporter][NFC] Improve test coverage (authored by Balazs Benics ). Changed prior to commit: htt

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

shafik accepted this revision. shafik added a comment. Thank you for adding these tests! LGTM Comment at: clang/unittests/AST/ASTImporterTest.cpp:3078 + EXPECT_TRUE(ToField->isBitField()); + EXPECT_EQ(3u, ToField->getBitWidthValue(ToTU->getASTContext())); +}

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99576/new/ https://reviews.llvm.org/D99576 __

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal created this revision. steakhal added reviewers: martong, teemperor, shafik, balazske, a.sidorin. Herald added subscribers: whisperity, rnkovacs, kristof.beyls. steakhal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All three cas