[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added a comment. In the future, please include `Differential Revision: ` for relands so that the `Commits` line displays the associated commits :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 __

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 added a comment. Relanded without -fno-initegrated-as case at https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 ___

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added a comment. In D99556#2664426 , @nickdesaulniers wrote: > In D99556#2662990 , @jcai19 wrote: > >> We can probably remove the -fno-integraetd-as case. > > Or split it out into a separate test file with

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. In D99556#2662990 , @jcai19 wrote: > We can probably remove the -fno-integraetd-as case. Or split it out into a separate test file with `// REQUIRES: linux`. Either actually is fine by me. Repository: rG LLVM Github

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 added a comment. We can probably remove the -fno-integraetd-as case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 ___ cfe-commits mailing list cfe-commi

[PATCH] D99556: Add support to -Wa,--version in clang

dyung added a comment. It also fails with the PS4 triple because we default to an external assembler that isn't present: https://lab.llvm.org/buildbot/#/builders/139/builds/2161/steps/6/logs/FAIL__Clang__as-version_s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. ah, sorry, I think we're missing a `// REQUIRES: linux` in the newly added test? I've pushed a revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 _

[PATCH] D99556: Add support to -Wa,--version in clang

thakis added a comment. Different error on windows: http://45.33.8.238/win/36132/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 ___ cfe-commits mailin

[PATCH] D99556: Add support to -Wa,--version in clang

thakis added a comment. Looks like the test fails on non-linux: http://45.33.8.238/macm1/6631/step_6.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llv

[PATCH] D99556: Add support to -Wa,--version in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jcai19 marked an inline comment as done. Closed by commit rG3cc3c0f8352e: Add support to -Wa,--version in clang (authored by jcai19). Changed prior to commit: https:

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/as-version.s:3 + +// RUN: %clang -Wa,--version -c -fintegrated-as %s -o /dev/null \ +// RUN: | FileCheck --check-prefix=IAS %s Delete excess spaces Repository: rG

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 added inline comments. Comment at: clang/test/Driver/as-version.s:9 +// RUN: | FileCheck --check-prefix=GAS %s +// GAS: GNU assembler nickdesaulniers wrote: > What happens if we run this on windows (where I suspect that GAS isn't > available)? Perhaps

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 updated this revision to Diff 334315. jcai19 marked an inline comment as done. jcai19 added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 Files: clang/lib/Driver/ToolChai

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added inline comments. Comment at: clang/test/Driver/as-version.s:9 +// RUN: | FileCheck --check-prefix=GAS %s +// GAS: GNU assembler What happens if we run this on windows (where I suspect that GAS isn't available)? Perhaps a `CHECK-NOT: clan

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 updated this revision to Diff 334277. jcai19 marked an inline comment as done. jcai19 added a comment. Update tests to address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 Files: clang

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. In D99556#2657509 , @MaskRay wrote: > gcc does not understand options in `-Wa,` so `-Wa,--version` needs to be used > this way: `gcc -Wa,--version -c -x assembler /dev/null -o /dev/null` > The verbose syntax makes it not t

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added inline comments. Comment at: clang/test/Driver/as-options.s:40 + +// RUN: %clang -Wa,--version -c -integrated-as %s -o /dev/null 2>&1 \ +// RUN: | FileCheck --check-prefix=NOWARN --allow-empty %s Drop `2>&1` because you specifically want to test

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added a comment. gcc does not understand options in `-Wa,` so `-Wa,--version` needs to be used this way: `gcc -Wa,--version -c -x assembler /dev/null -o /dev/null` The verbose syntax makes it not that useful. If the kernel really wants to use it, I have no issue with it. `-integrated-as

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 created this revision. jcai19 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang currently only supports -Wa,--version when -no-integrated-as is used. This adds support to -Wa,--version with -integrated-as. Link: https://github.c