[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

sammccall added a comment. In D99540#2799159 , @kadircet wrote: >> Sorry I've lost my context - did we decide to move forward with this patch? > > I don't think we've came to a conclusion, just decided to postpone until > needed. I believe the `cases` des

[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

kadircet added a comment. > Sorry I've lost my context - did we decide to move forward with this patch? I don't think we've came to a conclusion, just decided to postpone until needed. I believe the `cases` design is really a good fit for making tweaks expose multiple code actions. But we've a

[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

sammccall added a comment. Sorry I've lost my context - did we decide to move forward with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99540/new/ https://reviews.llvm.org/D99540 ___ cfe-com

[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

sammccall added a comment. Herald added a subscriber: cfe-commits. Sorry about taking forever to get around to this, I kept looking at it and not understanding it. IIUC the idea is: - tweaks depend on various data from the codeAction request - but we only have the codeAction request when enumer