This revision was automatically updated to reflect the committed changes.
Closed by commit rG66c05609e0d5: [RISCV][Clang] Add some RVV Integer intrinsic
functions. (authored by khchen).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99524/new/
https:
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99524/new/
https://reviews.llvm.org/D99524
_
khchen updated this revision to Diff 334164.
khchen added a comment.
1. Address Craig's comments.
2. I didn't add common class for shift instruction. I will add it when we add
other shift instruction which have the same argments. Does it make sense?
Repository:
rG LLVM Github Monorepo
CHANGE
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:432
+["vv", "Uv", "UvUvUv"],
+["vx", "Uv", "UvUvUe"]]>;
+
Should we have a common class for vadd/vsub/vand/vx
khchen added a comment.
So sorry.. those huge tests make the browser so slowly, should I split them in
the different patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99524/new/
https://reviews.llvm.org/D99524
_
khchen created this revision.
khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy,
jrtc27.
Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos,
sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,
brucehoult, MartinMosbeck, edward
