[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

2021-03-30 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbc4b0fc53e47: [clang-format] Fix east const pointer alignment of operators (authored by nrieck, committed by curdeius). Changed prior to commit: https://reviews.llvm.org/D99458?vs=333678&id=334173#toc

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

2021-03-29 Thread Nico Rieck via Phabricator via cfe-commits
nrieck added a comment. Ah, I missed transferring my commit access from svn. If anyone could commit for me, please do. In D99458#2655458 , @curdeius wrote: > Thinking out loud, do we test `volatile` at all? I see only the variants with block comments in

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

2021-03-29 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Thinking out loud, do we test `volatile` at all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99458/new/ https://reviews.llvm.org/D99458 ___ cfe-commits mailing list cfe-commit

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

2021-03-29 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99458/new/ https://reviews.llvm.org/D99458 ___ cfe-commits maili

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

2021-03-27 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2958 // Space between the type and the * in: // operator void*() // operator char*() Nit: you might add `operator void const/volatile*()` to the list. Repository:

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

2021-03-27 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. But please wait for @mydeveloperday's review too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99458/new/ https://reviews.llvm.org/D9

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

2021-03-27 Thread Nico Rieck via Phabricator via cfe-commits
nrieck created this revision. nrieck requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes left pointer alignment after pointer qualifiers of operators. Currently "operator void const*()" is formatted with a space between const a