This revision was automatically updated to reflect the committed changes.
Closed by commit rG3da61ddae7fe: [OpenMP] Define omp_is_initial_device()
variants in omp.h (authored by hbae).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99447/new/
https:/
JonChesterfield accepted this revision.
JonChesterfield added a comment.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99447/new/
https://reviews.llvm.org/D99447
___
cfe-commits mailing lis
hbae updated this revision to Diff 335347.
hbae added a comment.
Added inline after static to avoid unused function warning.
Added a RUN line to the test to catch unused function warning.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99447/new/
htt
JonChesterfield added a comment.
Nice, thanks! I think the function in the devicertl is dead with this change,
maybe remove that too?
Comment at: openmp/runtime/src/include/omp.h.var:479
+# endif
+
# undef __KAI_KMPC_CONVENTION
jdoerfert wrote:
> hbae wro
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, thanks
Comment at: openmp/runtime/src/include/omp.h.var:479
+# endif
+
# undef __KAI_KMPC_CONVENTION
hbae wrote:
> jdoerfert wrote:
> > Do we
hbae added inline comments.
Comment at: openmp/runtime/src/include/omp.h.var:479
+# endif
+
# undef __KAI_KMPC_CONVENTION
jdoerfert wrote:
> Do we want them to be static? I would have expected odr linkage instead.
>
>
>
Current clang fails to link two fil
hbae updated this revision to Diff 335034.
hbae added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Removed omp_is_initial_device() from clang built-ins.
Added a new test under openmp/libomptarget.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
