[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-30 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari abandoned this revision. vzakhari added a comment. The revision was split into: D99612 , D99551 , D99552 , D99553 CHANGES SINCE LAST ACTION https://re

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-29 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari added a comment. In D99360#2654244 , @MaskRay wrote: >> It might make sense to do the llvm-readobj portions of this patch in a >> separate review, since they are somewhat independent. > > +1. Patches touching BinaryFormat/llvm-readobj/yaml2obj/et

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > It might make sense to do the llvm-readobj portions of this patch in a > separate review, since they are somewhat independent. +1. Patches touching BinaryFormat/llvm-readobj/yaml2obj/etc part and others (MC/CodeGen/etc) are often required to do BinaryFormat/llvm-read

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-26 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari added a comment. In D99360#2652523 , @jhenderson wrote: > It might make sense to do the llvm-readobj portions of this patch in a > separate review, since they are somewhat independent. I agree. I actually have them in two patches, but I squashe

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-26 Thread James Henderson via Phabricator via cfe-commits
jhenderson added a comment. It might make sense to do the llvm-readobj portions of this patch in a separate review, since they are somewhat independent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 ___

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-25 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari updated this revision to Diff 333484. vzakhari edited the summary of this revision. vzakhari added a comment. Fixed issues detected in Windows testing downstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 Files: clang/tools/clan

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-25 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari updated this revision to Diff 78. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 Files: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp llvm/include/llvm/BinaryFormat/ELF.h llvm/tools/llvm-readobj/ELFDumper.cpp open

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

2021-03-25 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari created this revision. vzakhari added a project: OpenMP. Herald added subscribers: kerbowa, rupprecht, guansong, yaxunl, mgorny, nhaehnle, jvesely. Herald added a reviewer: alexshap. Herald added a reviewer: jhenderson. vzakhari requested review of this revision. Herald added subscribers: