LevyHsu updated this revision to Diff 334328.
LevyHsu added a comment.
1. clang/lib/Headers/riscv_zbb_intrin.h
- Fixed llvm header and other style issues.
2. clang/lib/Headers/rvintrin.h
- Fixed llvm header and other style issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
LevyHsu updated this revision to Diff 334073.
LevyHsu added a comment.
1. clang/lib/Headers/riscv_zbb_intrin.h
- Remove extra ports. now orc_b handles xlen op,
- _rv64_orc_b and _rv32_orc_b for RV64
- _rv32_orc_b for RV32
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
LevyHsu updated this revision to Diff 333801.
LevyHsu added a comment.
1. Generated with git format-patch -o patches/ -2 HEAD -U99
2. clang/lib/Headers/riscv_zbb_intrin.h
- Added corresponding 32/64 orcb intrinsic
- include error message when user include this file directly.
Repository:
kito-cheng added inline comments.
Comment at: clang/lib/Headers/riscv_zbb_intrin.h:18
+// Zbb
+static __inline__ int_xlen_t __DEFAULT_FN_ATTRS _rv_orc_b(int_xlen_t rs1) {
+ return __builtin_riscv_orc_b(rs1);
craig.topper wrote:
> craig.topper wrote:
> > I think
craig.topper added inline comments.
Comment at: clang/lib/Headers/riscv_zbb_intrin.h:18
+// Zbb
+static __inline__ int_xlen_t __DEFAULT_FN_ATTRS _rv_orc_b(int_xlen_t rs1) {
+ return __builtin_riscv_orc_b(rs1);
craig.topper wrote:
> I think rather than int_xlen_t
craig.topper added inline comments.
Comment at: clang/lib/Headers/riscv_zbb_intrin.h:18
+// Zbb
+static __inline__ int_xlen_t __DEFAULT_FN_ATTRS _rv_orc_b(int_xlen_t rs1) {
+ return __builtin_riscv_orc_b(rs1);
I think rather than int_xlen_t we want an int32_t ve