[PATCH] D99299: Normalize interaction with boolean attributes

2021-04-22 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:660-663 +bool AttributeImpl::getValueAsBool() const { + assert(getValueAsString().empty() || getValueAsString() == "false" || getValueAsString() == "true"); + return getValueAsString() == "true"; +

[PATCH] D99299: Normalize interaction with boolean attributes

2021-04-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:660-663 +bool AttributeImpl::getValueAsBool() const { + assert(getValueAsString().empty() || getValueAsString() == "false" || getValueAsString() == "true"); + return getValueAsString() == "true"; +} ---

[PATCH] D99299: Normalize interaction with boolean attributes

2021-04-16 Thread serge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. serge-sans-paille marked an inline comment as done. Closed by commit rGd6de1e1a7140: Normalize interaction with boolean attributes (authored by serge-sans-paille). Hera