[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

2021-03-30 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder abandoned this revision. tbaeder added a comment. Abandoning in favor of https://reviews.llvm.org/D97362 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278 ___ cfe-commits mailing list cfe-commits

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

2021-03-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D99278#2657664 , @tbaeder wrote: > This (and https://reviews.llvm.org/D99338) are both NFC changes once > https://reviews.llvm.org/D97362 lands (they need the three-parameter version > of `ProhibitCXX11Attributes()`). I

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

2021-03-29 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. All the attribute patches are just preparations so I can finally enable the source locations in GNU attributes in https://reviews.llvm.org/D75844. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

2021-03-29 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. This (and https://reviews.llvm.org/D99338) are both NFC changes once https://reviews.llvm.org/D97362 lands (they need the three-parameter version of `ProhibitCXX11Attributes()`). I can merge the three into one patch if you prefer. CHANGES SINCE LAST ACTION https://r

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

2021-03-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. To be clear, this is expected to be an NFC change that allows D97362 to be applied without breaking bots? If so, it'd be helpful to have the changes as part of D97362 because they're critical to t

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

2021-03-25 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 333226. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278 Files: clang/lib/Parse/ParseDeclCXX.cpp Index: clang/lib/Parse/ParseDeclCXX.cpp === -

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

2021-03-24 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith, rjmccall. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sorry for the title, I'm not 100% sure that's even correct here. This call to `ProhibitAttribu