[PATCH] D99235: [HIP] Change to code object v4

2021-05-18 Thread Greg Rodgers via Phabricator via cfe-commits
gregrodgers added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { yaxunl wrote: > tra wrote: > > We

[PATCH] D99235: [HIP] Change to code object v4

2021-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:24-39 // Check bundle ID for code object v2. // RUN: %clang -### -target x86_64-linux-gnu \ // RUN: -mno-code-object-v3 \ // RUN: --offload-a

[PATCH] D99235: [HIP] Change to code object v4

2021-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG4fd05e0ad7fb: [HIP] Change to code object v4 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99235: [HIP] Change to code object v4

2021-04-06 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Still LGTM. Comment at: clang/test/Driver/hip-code-object-version.hip:24-39 // Check bundle ID for code object v2. // RUN: %clang -### -target x86_64-linux-gnu \ // RUN: -mno-code-object-v3 \ // RUN: --offload-arch=gfx906 -nogpulib \ // RUN: %s

[PATCH] D99235: [HIP] Change to code object v4

2021-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:115 std::string OffloadKind = "hip"; + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; --

[PATCH] D99235: [HIP] Change to code object v4

2021-04-06 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:115 std::string OffloadKind = "hip"; + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = O

[PATCH] D99235: [HIP] Change to code object v4

2021-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99235/new/ https://reviews.llvm.org/D99235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D99235: [HIP] Change to code object v4

2021-03-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { ---

[PATCH] D99235: [HIP] Change to code object v4

2021-03-24 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { We do not do it for v2/v3. Could you elabo

[PATCH] D99235: [HIP] Change to code object v4

2021-03-23 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Change to code object v4 by default to match ROCm 4.1. This is upstream of code object v4 support from amd-stg-open branch. https://reviews.llvm.org/D99235 Files: clang/lib/Driver/ToolChains