[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl updated this revision to Diff 339353. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99233/new/ https://reviews.llvm.org/D99233 Files: clang

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:954 +def gpu_inline_threshold_EQ : Joined<["--"], "gpu-inline-threshold=">, + Flags<[CC1Option]>, + HelpText<"Inline threshold for device compilation for HIP

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

tra added a comment. > The planned new option for offloading will be a more generic solution, > however, I expect it will take time to develop and be adopted. Agreed. OK, let's use a hidden option until we have a better way of dealing with this. Comment at: clang/include/cla

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl added a comment. In D99233#2656446 , @tra wrote: > I'm concerned that if we make it a top-level option, it's likely to be > cargo-culted and (mis)used as a sledgehammer in cases where it's not needed. > I think the option should remain hidden. > >

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

tra added a comment. I'm concerned that if we make it a top-level option, it's likely to be cargo-culted and (mis)used as a sledgehammer in cases where it's not needed. I think the option should remain hidden. While thresholds do need to be tweaked, in my experience it happens very rarely. W

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: jansvoboda11, dang. yaxunl requested review of this revision. Add option --gpu-inline-threshold for inline threshold for device compilation only. https://reviews.llvm.org/D99233 Files: clang/include/clang/D