[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

This revision was automatically updated to reflect the committed changes. Closed by commit rG18192228602c: [clang] tests: cleanup, update and add some new ones (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. This looks fine to me. Maybe wait for a day or two to see if richardsmith wants to say anything, else this is good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

Quuxplusone added a comment. There's unlikely to be any further substantive comments from me, and this basically LGTM (or, in the places it looks bad, it's just the pre-existing awfulness of how the Clang test suite is organized). I think you need to either get someone's attention to approve thi

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335599. mizvekov added a comment. - Finally addresses all of Arthur's review requests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org/D99225 Files: clang/test/CXX/class/cl

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/SemaCXX/coroutine-rvo.cpp:41-45 struct MoveOnly { - MoveOnly() {}; + MoveOnly() = default; MoveOnly(const MoveOnly&) = delete; - MoveOnly(MoveOnly&&) noexcept {}; - ~MoveOnly() {}; + MoveOnly(MoveOnly &&) = default;

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335121. mizvekov added a comment. - Addresses most of Arthur's points. - Re-adds test coverage for `conversion-function.cpp` and `temp.mem/p5.cpp` with no C++ version specified. - Adds a couple more tests on nrvo-tracking for blocks returning references. R

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/SemaCXX/conversion-function.cpp:160 + return "Hello"; // cxx98_14-error {{calling a private constructor}} #if __cplusplus <= 199711L // expected-warning@-2 {{an accessible copy constructor}} mizvekov wro

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335055. mizvekov added a comment. Just rebased, removing trailing whitespace noise. Other review points to be addressed later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added a comment. @Quuxplusone Thank you for the review. All your points are good ones and will be addressed in time! The new NRVO propagation `clang/test/CodeGen/nrvo-tracking.cpp` is also breaking on the buildbot, but it works on my machine. Will also take a look at that one. =

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

Quuxplusone added a comment. LGTM (just a bunch of style comments from me), but I think you'll have to get someone else's attention if you're expecting to get signoff from someone to land this. I also think it would make sense for you to land the absolutely trivial trailing-whitespace diffs ri