[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + Naghasan wrote: > ABataev wrote: > > ba

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

Naghasan added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + ABataev wrote: > bader wrote: > > Na

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell added inline comments. Comment at: clang/docs/SYCLSupport.md:73 +the integration header is used (included) by the SYCL runtime implementation, so +the header must be available before the host compilation starts.* + bader wrote: > Naghasan wrote: > > > Fi

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell added a comment. In D99190#2659571 , @tschuett wrote: > The OMPIRBuilder is the modern version of late outlining: > https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h > You may consider to go that way wi

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

tschuett added a comment. The OMPIRBuilder is the modern version of late outlining: https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h You may consider to go that way with SYCL as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

ABataev added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + bader wrote: > Naghasan wrote: > > Op

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added a subscriber: ABataev. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:73 +the integration header is used (included) by the SYCL runtime implementation, so +the header must be available before the host compilation starts.* + Naghas

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader marked 8 inline comments as done. bader added a comment. @Anastasia, I've addressed the comments for the address space section in https://reviews.llvm.org/D99488. Let's move discussion there. Comment at: clang/docs/SYCLSupport.md:861 +space for types with no address spac

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

Naghasan requested changes to this revision. Naghasan added a comment. This revision now requires changes to proceed. Added comment for the front end support part. I think the document present to much at once, front-end, driver, tool chains, SPIR-V backend, compiler-runtime bindings etc. It is g

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333780. bader added a comment. Move address space handling section to https://reviews.llvm.org/D99488 to address https://reviews.llvm.org/D89909#2653452. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

Anastasia added inline comments. Comment at: clang/docs/SYCLSupport.md:857 +The main address space semantic difference of SYCL mode from OpenCL is that +SYCL doesn't assign OpenCL generic address space to a declaration's type without +explicit address space attribute. Similar to

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333581. bader added a comment. Add links to SYCL specification with address space behavior description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files: clang/doc

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader marked an inline comment as done. bader added a comment. In D99190#2652054 , @keryell wrote: >> ! In D99190#2650326 , @bader wrote: >> >> 2. I'm looking for suggestions on "OpenCL extensions" clarification. >

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333502. bader added a comment. Resolve "OpenCL extensions" ambiguity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files: clang/docs/SYCLSupport.md clang/docs/imag

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell added a comment. > ! In D99190#2650326 , @bader wrote: > > 2. I'm looking for suggestions on "OpenCL extensions" clarification. I said that "OpenCL extensions" are misleading because it can be understood as either extensions inside OpenCL (`cl_khr

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added a comment. @keryell, thanks for the feedback. I applied your suggestions with two exceptions: 1. I'm not sure if other back-ends need special processing for kernel function parameters we apply for SPIR kernels. 2. I'm looking for suggestions on "OpenCL extensions" clarification.

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333279. bader marked 16 inline comments as done. bader added a comment. Apply most of the comments from Ronan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files: cl

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell requested changes to this revision. keryell added a comment. This revision now requires changes to proceed. Great to have some design documentation! Just a feedback on the first 20%... Comment at: clang/docs/SYCLSupport.md:23 +files (which are really LLVM IR files) are