Naghasan accepted this revision.
Naghasan added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99190/new/
https://reviews.llvm.org/D99190
___
cfe-commits mailing list
cfe-commits@lists.llv
bader marked 2 inline comments as done.
bader added inline comments.
Comment at: clang/docs/SYCLSupport.md:51
+virtual calls), generates LLVM IR for the device code only and an "integration
+header" which provides information like kernel name, parameters order and data
+type for
bader marked an inline comment as done.
bader added inline comments.
Comment at: clang/docs/SYCLSupport.md:123
+traverse all symbols accessible from kernel functions and add them to the
+"device part" of the code marking them with the new SYCL device attribute.
+
Naghasan added inline comments.
Comment at: clang/docs/SYCLSupport.md:123
+traverse all symbols accessible from kernel functions and add them to the
+"device part" of the code marking them with the new SYCL device attribute.
+
bader wrote:
> Naghasan wrote:
> > A
bader created this revision.
Herald added subscribers: mstorsjo, Anastasia, ebevhan, yaxunl.
bader requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
Initial version of the document covers most of t
