This revision was automatically updated to reflect the committed changes.
Closed by commit rG821547cabb58: [RISCV][Clang] Update new overloading rules
for RVV intrinsics. (authored by khchen).
Changed prior to commit:
https://reviews.llvm.org/D99189?vs=333486&id=333727#toc
Repository:
rG LLV
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM other than those typos
Comment at: clang/include/clang/Basic/riscv_vector.td:161
+ // This builtin supports non-masked function overloading api.
+ // All m
khchen updated this revision to Diff 333486.
khchen added a comment.
remove riscv_vector_overloaded.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99189/new/
https://reviews.llvm.org/D99189
Files:
clang/include/clang/Basic/riscv_vector.td
cla
liaolucy added inline comments.
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:10
// This tablegen backend is responsible for emitting riscv_vector.h and
-// riscv_vector_generic.h, which includes a declaration and definition of each
-// intrinsic fucntions specified in http
khchen updated this revision to Diff 333298.
khchen marked an inline comment as done.
khchen added a comment.
Emit riscv_vector_overloaded.h into riscv_vector.h
Remove riscv_vector_overloaded.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99189/new
khchen marked 3 inline comments as done.
khchen added inline comments.
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c:11
// ASM-NOT: warning
-#include
+#include
liaolucy wrote:
> riscv_vector_overloaded.h ?
Sorry, I forget to have a di
liaolucy added inline comments.
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c:11
// ASM-NOT: warning
-#include
+#include
riscv_vector_overloaded.h ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
khchen updated this revision to Diff 332852.
khchen added a comment.
Fix unintended change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99189/new/
https://reviews.llvm.org/D99189
Files:
clang/include/clang/Basic/riscv_vector.td
clang/lib/Hea
craig.topper added inline comments.
Comment at: llvm/docs/CommandGuide/tblgen.rst:133
- Generate generic automata.
+ Generate overloaded automata.
This looks like an unintended change
Comment at: llvm/docs/CommandGuide/tblgen.rst:279
-
khchen created this revision.
khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy,
jrtc27.
Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos,
sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,
brucehoult, MartinMosbeck, edward
10 matches
Mail list logo