[PATCH] D99145: [clang] Fix a crash when CTAD fails

2021-03-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f80c66bd298: [clang] Fix a crash when CTAD fails (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D99145: [clang] Fix a crash when CTAD fails

2021-03-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 332619. kadircet added a comment. - Move test into existing file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99145/new/ https://reviews.llvm.org/D99145 Files: clang/lib/Sema/SemaChecking.cpp clang/test

[PATCH] D99145: [clang] Fix a crash when CTAD fails

2021-03-23 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/Sema/check-arg-alignment.cpp:1 +// Ensure we don't crash when CTAD fails. +// RUN: %clang_cc1 -std=c++17 -verify %s I'd move t

[PATCH] D99145: [clang] Fix a crash when CTAD fails

2021-03-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99145 Files: clang/lib/Sema/SemaChecking.cpp c