[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3085bda2b348: [analyzer][solver] Fix infeasible constraints (PR49642) (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 332211. vsavchenko added a comment. Re-write the test using %clang_analyze_cc1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98948/new/ https://reviews.llvm.org/D98948 Files: clang/lib/StaticAnalyzer/Core

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/test/Analysis/PR49642.c:1 +// RUN: %clang --analyze -Xclang -analyzer-checker=core %s + vsavchenko wrote: > NoQ wrote: > > Why not the usual `%clang_analyze_cc1`? Your approach only adds driver > > testing which doesn

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-19 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added inline comments. Comment at: clang/test/Analysis/PR49642.c:1 +// RUN: %clang --analyze -Xclang -analyzer-checker=core %s + NoQ wrote: > Why not the usual `%clang_analyze_cc1`? Your approach only adds driver > testing which doesn't seem to test a

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Aha ok, seems reasonable, thx! Comment at: clang/test/Analysis/PR49642.c:1 +// RUN: %clang --analyze -Xclang -analyzer-checker=core %s + Why not the usual `%clang_analyze_cc1`? Your approach only adds driver test

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-19 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Aa, get it. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98948/new/ https://reviews.llvm.org/D98948 __

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-19 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 331863. vsavchenko added a comment. Fix typos in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98948/new/ https://reviews.llvm.org/D98948 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManag

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

2021-03-19 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: steakhal, NoQ, xazax.hun, ASDenysPetrov. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald