[PATCH] D98881: [RISCV] Fix mcount name for Linux

2021-03-18 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. Such a diff does not look too bad: diff --git a/clang/lib/Basic/Targets/OSTargets.h b/clang/lib/Basic/Targets/OSTargets.h index 539466c4f678..c32972c1e04e 100644 --- a/clang/lib/Basic/Targets/OSTargets.h +++ b/clang/lib/Basic/Targets/OSTargets.h @@ -256,6

[PATCH] D98881: [RISCV] Fix mcount name for Linux

2021-03-18 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. Would it be better to hoist it into `RISCVTargetInfo` and modify the BSD switch statements to respect that in their respective TargetInfo constructors? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98881/new/ https://

[PATCH] D98881: [RISCV] Fix mcount name for Linux

2021-03-18 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. This should really be for all OSes on RISC-V, which I think means copying it N times? :/ (GCC defines MCOUNT_NAME in riscv/riscv.h, not riscv/linux.h) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98881/new/ https://review

[PATCH] D98881: [RISCV] Fix mcount name for Linux

2021-03-18 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance created this revision. Herald added subscribers: vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c