This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGef58ae86ba77: [RISCV] Fix mcount name (authored by
nathanchance).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews
nathanchance updated this revision to Diff 333185.
nathanchance added a comment.
Drop "riscv32" and "riscv64" from list of checked triples (thanks to Fangrui
for catching it with a good explanation).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98
MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/CodeGen/mcount.c:17
+// RUN: %clang_cc1 -pg -triple riscv64 -emit-llvm -o - %s | FileCheck
-check-prefixes=CHECK-PREFIXED,NO-MCOUNT1 %s
+// RUN:
nathanchance updated this revision to Diff 332811.
nathanchance retitled this revision from "[RISCV] Fix mcount name for Linux" to
"[RISCV] Fix mcount name".
nathanchance edited the summary of this revision.
nathanchance added a comment.
Herald added subscribers: frasercrmck, apazos, jocewei, the_
nathanchance added a comment.
Such a diff does not look too bad:
diff --git a/clang/lib/Basic/Targets/OSTargets.h
b/clang/lib/Basic/Targets/OSTargets.h
index 539466c4f678..c32972c1e04e 100644
--- a/clang/lib/Basic/Targets/OSTargets.h
+++ b/clang/lib/Basic/Targets/OSTargets.h
@@ -256,6
nathanchance added a comment.
Would it be better to hoist it into `RISCVTargetInfo` and modify the BSD switch
statements to respect that in their respective TargetInfo constructors?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98881/new/
https://
jrtc27 added a comment.
This should really be for all OSes on RISC-V, which I think means copying it N
times? :/
(GCC defines MCOUNT_NAME in riscv/riscv.h, not riscv/linux.h)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98881/new/
https://review
nathanchance created this revision.
Herald added subscribers: vkmr, evandro, luismarques, sameer.abuasal,
s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook.
nathanchance requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-c
