[PATCH] D98774: [AST] De-duplicate empty node introspection

thakis added a comment. In D98774#2708108 , @steveire wrote: > In D98774#2701853 , @thakis wrote: > >> I think it is? https://llvm.org/docs/GettingStarted.html#software lists it >> at least. > > Thanks, I'll look i

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire added a comment. In D98774#2701853 , @thakis wrote: > I think it is? https://llvm.org/docs/GettingStarted.html#software lists it at > least. Thanks, I'll look into that soon and see how the buildbots respond. Repository: rG LLVM Github Monor

[PATCH] D98774: [AST] De-duplicate empty node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rGaee6c86c4dc7: [AST] De-duplicate empty node introspection (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D98774?vs=331300&id=339559#toc Repository: rG LLVM Github Monor

[PATCH] D98774: [AST] De-duplicate empty node introspection

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Definitely a step forward, so lg :) > AFAIK python is not a hard-requirement of the llvm/clang build. I think it is? https://llvm.org/docs/GettingStarted.html#software lists it at least. =

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire marked an inline comment as done. steveire added a comment. @thakis Do you have any more on this? Can we de-duplicate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98774/new/ https://reviews.llvm.org/D98774 __

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire marked 4 inline comments as done. steveire added a comment. In D98774#2631898 , @thakis wrote: > Why were there two copies in the first place? What was the copy in the cmake > file good for, why wasn't the one written by generate_cxx_src_locs.py

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire updated this revision to Diff 331300. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98774/new/ https://reviews.llvm.org/D98774 Files: clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling/DumpTool/generat

[PATCH] D98774: [AST] De-duplicate empty node introspection

thakis added a comment. Why were there two copies in the first place? What was the copy in the cmake file good for, why wasn't the one written by generate_cxx_src_locs.py sufficient? But pulling it into its own file seems nicer than having it inline in python or cmake code. Another observation

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire created this revision. steveire added reviewers: thakis, njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This way we can add support for other nodes without du