[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rG279ea930fa21: [clang] Add fixit for Wreorder-ctor (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for this! The changes LGTM, but wait to land it for a day or two in case @rsmith has concerns. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5242 + if (Pr

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331635. njames93 marked an inline comment as done. njames93 added a comment. Address nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/include/clang

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5242 + if (Previous->isAnyMemberInitializer()) +Diag << 0 << Previous->getAnyMember()->getDeclName(); + else aaron.ballman wrote: > This w

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8611 +def warn_some_initializers_out_of_order : Warning< + "some initializers aren't given in the correct order">, + InGroup, DefaultIgnore; Hmmm, how about `initi

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331582. njames93 added a comment. Arc got confused Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331581. njames93 added a comment. Fix formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/test/SemaCXX/constructor-initializer.cpp clang

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 created this revision. njames93 added reviewers: rsmith, sammccall, aaron.ballman. Herald added a subscriber: mgrang. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Create fix-it hints to fix the order of constructors. To