[PATCH] D98726: [analyzer] Remove unnecessary TODO

RedDocMD added a comment. @NoQ, regarding https://godbolt.org/z/1EczEW, I don't think there should be a warning since the original pointer may be needed in the caller. But thanks for pointing out the possible leaks due to release! :) In the line that you have pointed out, I have thought about the

[PATCH] D98726: [analyzer] Remove unnecessary TODO

RedDocMD updated this revision to Diff 331164. RedDocMD added a comment. Removed unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98726/new/ https://reviews.llvm.org/D98726 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeli

[PATCH] D98726: [analyzer] Remove unnecessary TODO

NoQ added a comment. In D98726#2629722 , @steakhal wrote: > For example this code does not trigger any warning: > https://godbolt.org/z/aM4xe7 FTFY: https://godbolt.org/z/vT5c7s This test isn't very interesting though because the warning doesn't have an

[PATCH] D98726: [analyzer] Remove unnecessary TODO

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I don't think the `TODO` is addressed. By checking the //git blame// quickly, there was no change committed to the `SmartPtrChecker` affecting the collaboration with the `MallocCh

[PATCH] D98726: [analyzer] Remove unnecessary TODO

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, steakhal. Herald added subscribers: ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. RedDocMD requested review of this revision. Herald adde