[PATCH] D98717: [AMDGPU] Split dot2-insts feature

2021-03-17 Thread Jay Foad via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG967b64beb4bf: [AMDGPU] Split dot2-insts feature (authored by foad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

2021-03-16 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM. Thanks Jay! Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:511 +def FeatureDot7Insts : SubtargetFeature<"dot7-insts", + "HasDot7Insts", + "true", a

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

2021-03-16 Thread Jay Foad via Phabricator via cfe-commits
foad added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:511 +def FeatureDot7Insts : SubtargetFeature<"dot7-insts", + "HasDot7Insts", + "true", arsenm wrote: > I'm not sure where the "7" is coming from It's the next number after 6. I don't think

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

2021-03-16 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:511 +def FeatureDot7Insts : SubtargetFeature<"dot7-insts", + "HasDot7Insts", + "true", I'm not sure where the "7" is coming from Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

2021-03-16 Thread Jay Foad via Phabricator via cfe-commits
foad created this revision. foad added reviewers: rampitec, kzhuravl, b-sumner. Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, arsenm. foad requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added pr