[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

2021-03-18 Thread Thomas Lively via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5764a8654e3: [WebAssembly] Finalize SIMD names and opcodes (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D98676?vs=330

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

2021-03-16 Thread Thomas Lively via Phabricator via cfe-commits
tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1243 // Prototype f64x2 conversions defm "" : SIMDConvert If they are finalized, can we delete these "prototype" comments here and > elsewhere? (not necessarily in this CL) Yes, th

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

2021-03-16 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1243 // Prototype f64x2 conversions defm "" : SIMDConverthttps://reviews.llvm.org/D98676/new/ https

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

2021-03-15 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. U