[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 added a comment. In D98657#2701673 , @crownyanguan wrote: > How about -Wl option, it will cause link error like " Only `-Werror` is > supported currently" Thanks for pointing it out. The issue was due to restricting -W` options in `f18` as

[PATCH] D98657: [flang][driver] Add options for -Werror

crownyanguan added a comment. How about -Wl option, it will cause link error like " Only `-Werror` is supported currently" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 _

[PATCH] D98657: [flang][driver] Add options for -Werror

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7416e8a8431a: [flang][driver] Add options for -Werror (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you for addressing my comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 _

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 335255. arnamoy10 added a comment. Adding newline at the end of a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Fla

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 335246. arnamoy10 added a comment. 1. Separated test cases to check prescan, parse and sema differently. 2. Diagnostics is thrown when anything other that `error` is given for `-W`. This behaviour is reflected in `f18 CHANGES SINCE LAST ACTION https://

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski added a comment. I really like how you split your tests into two files: - `werror_scan.f` captures warning generated by the prescanner - `werror.f` captures warnings from the semantic analysis In every case you added multiple RUN lines to make sure that the behavior is consistent acr

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 333843. arnamoy10 added a comment. Modifying the test cases to: 1. Make it work for `f18` (when `flang-new` is not installed) 2. Adding more options and one test case to check correct functionality with `PrescanAction` and `PrescanAndSemaAction` CHANGES

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski added a comment. I see that `-Werror` changes the behavior of the driver in 5 different places. I would hope to see 5 new tests to verify each case. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:353-354 +/// Parses all semantic related arguments and popul

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 332997. arnamoy10 added a comment. rebasing on top of main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inc

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 332692. arnamoy10 added a comment. Thanks @awarzynski for the comments. 1. Moving diagnostics options parsing to a separate function 2. Adding a check so that `-Wblah` does not trigger the treatment of warnings as werrors, only `-Werror` triggers it 3. Add

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 added inline comments. Comment at: flang/test/Semantics/dosemantics03.f90:1-2 ! RUN: %S/test_errors.sh %s %t %f18 -Mstandard -Werror +! RUN: %S/test_errors.sh %s %t %flang_fc1 -Werror awarzynski wrote: > Rather than adding the 2nd line, could you upd

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski added a comment. Thank you for adding this @arnamoy10 ! I think that in order to match the semantics of `-Werror` from `f18`, this patch needs to be extended a bit. In the following two cases, `f18` will exit immediately, whereas `flang-new -fc1` will happily carry-on: - https://g

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 331009. arnamoy10 added a comment. Updating to use available option from `Options.td` instead of creating a new option for `-Werror` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files: clang/include/

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, SouraVX, tskeith, AMDChirag, sscalpone, bryanpkc. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the follo