[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401953. glaubitz edited the summary of this revision. glaubitz added a comment. Minor improvement to the commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D9

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401951. glaubitz edited the summary of this revision. glaubitz added a comment. Updated the patch as requested and dropped all changes except the removal of __sparcv9 and __sparcv9__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401950. glaubitz added a comment. Made changes according to review and dropped every change except removing __sparcv9 and __sparcv9__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +//

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

hvdijk added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +// S

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. In D98574#2654686 , @joerg wrote: > The NetBSD part looks ok, but also lacks proper testing. I'm not sure anyone > but Linux cares at all otherwise as they lack 32bit SPARC support. Well, there were no tests for NetBSD before, s

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

joerg added a comment. The NetBSD part looks ok, but also lacks proper testing. I'm not sure anyone but Linux cares at all otherwise as they lack 32bit SPARC support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.or

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

brad added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +// Sol

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz marked an inline comment as done. glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz marked an inline comment as done. glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +// Solar

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Updated as I previously forgot to account for FreeBSD as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing l

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332567. glaubitz edited the summary of this revision. Herald added subscribers: arichardson, emaste. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/B

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332380. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Targets/Sparc.cpp clang/test/Preprocessor/predefined-arch-macros.c Index: clang/test

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. I have updated the patch now with the result that clang should behave as GCC now on Linux, NetBSD and OpenBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332339. glaubitz edited the summary of this revision. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Ta

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

brad added a comment. In D98574#2641697 , @glaubitz wrote: > `-m32` is not supported on OpenBSD at all: > > openbsd# echo | gcc -E -dM -m32 - > :0: error: -m32 is not supported by this configuration > openbsd# Yes. OpenBSD has no 32-bit

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. For reference, here is what GCC defines on Linux with regards to SPARC: glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep arch glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep LP glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep v9 #de

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332320. glaubitz edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Targets/Sparc.cpp clang/test/Preprocesso

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332312. glaubitz retitled this revision from "[Sparc] Define the same macros for -mcpu=v9 as GCC on Linux" to "[Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs". glaubitz edited the summary of this revision. Repository: rG LLVM Gi

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

glaubitz added a comment. In D98574#2624558 , @brad wrote: > I do not immediately see why the other tests are failing, but at a bare > minimum the following test from > clang/test/Preprocessor/predefined-arch-macros.c will have to be updated.. > > // R

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:160-164 + // Linux doesn't need these variants, but the BSDs do. + if (getTriple().getOS() != llvm::Triple::Linux) { +Builder.defineMacro("__sparcv9"); +Builder.defineMacro("__

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/Sparc.cpp:160-164 + // Linux doesn't need these variants, but the BSDs do. + if (getTriple().getOS() != llvm::Trip

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

brad added a comment. I do not immediately see why the other tests are failing, but at a bare minimum the following test from clang/test/Preprocessor/predefined-arch-macros.c will have to be updated.. // RUN: %clang -mcpu=v9 -E -dM %s -o - 2>&1 \ // RUN: -target sparc-unknown-linux \

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

glaubitz created this revision. glaubitz added reviewers: jrtc27, ro, efriedma, brad, jfb, venkatra, jyknight. Herald added a subscriber: fedor.sergeev. glaubitz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting SPARC V8+ or V9