This revision was automatically updated to reflect the committed changes.
Closed by commit rG7e0cc45ced23: [SystemZ][z/OS] Save strings for CC_PRINT env
vars (authored by SeanP, committed by muiez).
Changed prior to commit:
https://reviews.llvm.org/D98554?vs=332836&id=333625#toc
Repository:
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM; thanks.
Comment at: clang/lib/Driver/Driver.cpp:4042
- if (!CCPrintStatReportFilename) {
+ if (CCPrintStatReportFilename.emp
SeanP marked 2 inline comments as done.
SeanP added inline comments.
Comment at: clang/include/clang/Driver/Driver.h:160
/// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled.
- const char *CCPrintStatReportFilename;
+ std::string CCPrintStatReportFilename;
---
SeanP updated this revision to Diff 332836.
SeanP added a comment.
Changed the code checking the env vars so it doesn't assign a null_ptr to the
string.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98554/new/
https://reviews.llvm.org/D98554
Files:
clang/include/clang/Driver/Driver
hubert.reinterpretcast added inline comments.
Comment at: clang/include/clang/Driver/Driver.h:160
/// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled.
- const char *CCPrintStatReportFilename;
+ std::string CCPrintStatReportFilename;
I'm seein
SeanP created this revision.
SeanP added reviewers: hubert.reinterpretcast, uweigand, Kai.
SeanP requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The contents of the string returned by getenv() is not guaranteed across calls
to getenv(). T
