This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb5b2c81055cf: [clangd] Propagate data in diagnostics
(authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D98505?vs=333982&id
kadircet updated this revision to Diff 333982.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98505/new/
https://reviews.llvm.org/D98505
Files:
clang-tools-ex
kadircet marked 4 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Diagnostics.h:77
+ // list.
+ std::vector OpaqueData;
};
sammccall wrote:
> Hmm, you've replaced the json::Array with an array of objects :-)
> Any
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Diagnostics.h:77
+ // list.
+ std::vector OpaqueData;
};
Hmm, you've replaced the json::Array with an array
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Diagnostics.h:58
+ /// If true, Clangd will populate the data field in LSP diagnostic
+ /// representation. This is used to prevent extra data transfer with old
+ /// clients that doesn't support data field.
kadircet updated this revision to Diff 332636.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Ignore capability
- Store data as a json::Object rather than an Array.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98505/new/
ht
sammccall added inline comments.
Herald added a project: clang-tools-extra.
Comment at: clang-tools-extra/clangd/Diagnostics.h:58
+ /// If true, Clangd will populate the data field in LSP diagnostic
+ /// representation. This is used to prevent extra data transfer with old
+ /
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
http
