[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

asl added a comment. Indeed! And even worse, there is another 'A' shadowing definition below :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 ___ cfe-commits ma

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov added a comment. The patch was wrong. We use "const Arg *A" at the end of GetLinkerPath, so can't remove it. I thought I tested this, but, apparently, not. Reverted in 62948c4532d59b59f63409eae5d7f9e4990e5626

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6802fdf8871f: [NFC] Minor cleanup to use default setting of getLastArg() (authored by maxim-kuvyrkov). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Looks trivial enough for post-commit review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 _

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov updated this revision to Diff 330273. maxim-kuvyrkov added a comment. Fixed thinko: GetLastArg -> GetLastArgValue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 Files: clang/lib/Driver/Too

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Noticed this while I was looking at linker defaults. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98494 Files: cla