[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd672d5219a72: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue" (authored by arphaman). Changed prior to commit: https://reviews.llvm.

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

davide added a comment. + Lang, who probably has a better understanding of this, for visibility. I don't think this should be blocked further, but he might have a chance to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98458/new/ https://

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98458/new/ https://reviews.llvm.org/D98458 ___

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

davide added a comment. In D98458#2620731 , @MaskRay wrote: >> Mach-O doesn't support dso_local and this change broke XNU because of the >> use of dso_local. > > Can you elaborate on the unsupportness? For example, the backend can ignore > dso_local if i

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

MaskRay added a comment. > Mach-O doesn't support dso_local and this change broke XNU because of the use > of dso_local. Can you elaborate on the unsupportness? For example, the backend can ignore dso_local if it does not want to support it. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

arphaman created this revision. arphaman added reviewers: davide, MaskRay. Herald added subscribers: ributzka, jkorous. arphaman requested review of this revision. Herald added a project: clang. This reverts commit 809a1e0ffd7af40ee27270ff8ba2ffc927330e71