This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3b99731c4e7b: [clangd] Turn off implicit cancellation based
on client capabilities (authored by sammccall).
Herald added a project: clang-tools-extra
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/ClangdServer.h:153
+/// to cancel. Clients that always cancel stale requests should clear this.
+bool ImplicitC
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.h:153
+/// to cancel. Clients that always cancel stale requests should clear this.
+bool ImplicitCancellation = true;
+
kadircet wrote:
> this makes sense as is, but i wond
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.h:153
+/// to cancel. Clients that always cancel stale requests should clear this.
+bool ImplicitCancellation = true;
+
this makes sense as is, but i wonder if we should lif
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Capability is in upcoming 3.17:
https://
