[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

2021-03-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D98251#2615049 , @NoQ wrote: > Looks all clear. > > In that document there's also a clause that the conventional completion > handler discovered through its suffix has to be the //last// parameter. I > don't immediately see

[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

2021-03-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59112eacb979: [-Wcompletion-handler] Extend list of detected conventions (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

2021-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks all clear. In that document there's also a clause that the conventional completion handler discovered through its suffix has to be the //last// parameter. I don't immediately see that respect

[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

2021-03-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update convention detection to accomodate changes from: https://github.com/D