[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet planned changes to this revision. kadircet added a comment. Herald added a project: clang-tools-extra. as discussed offline, this gets messy if the header can be included both as a system and quoted included, and the coding style actually prefers the quoted one. it is not a big deal yet

[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet updated this revision to Diff 329930. kadircet added a comment. - Rebase - Add a storage for returned verbatim header spellings, as getHeaderIncludeUncached can only return a ref. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98242/new/ h

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall added a comment. I've landed the caching patch so this is good to go. The merge is *conceptually* trivial but the enclosing function has moved so you may need to reapply it by hand, sorry... Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 + if (Is

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall added a comment. I measured this as a mild (3%) increase in preamble indexing time when working on clangd itself, more details in D98329 This regression could be more significant with a long include search path, so I'd like to avoid adding this withou

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think this is going to be more good than bad, and the alternatives are terrifically complicated. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 +

[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 + if (IsSystem) +return "<" + ShorterInclude + ">"; // Standard case: just insert the file itself. sammccall wrote: > This is a great heuristic, now I'm thi

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 + if (IsSystem) +return "<" + ShorterInclude + ">"; // Standard case: just insert the file itself. This is a great heuristic, now I'm thinking of all the w

[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This makes our index more portable between