This revision was automatically updated to reflect the committed changes.
Closed by commit rG14a7296c0120: [clang][clangd] Avoid inconsistent target
creation (authored by oToToT).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98128/new/
https://revi
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
sorry for the delay here. thanks, this LGTM!
i've got a single concern in `CompilerInstance::createTarget` though. it will
overwrite aux target for cuda, openmp and sycl (as it uncondition
oToToT added a comment.
ping.
After some investigation, I think it is quite hard to add tests to avoid
inconsistency between clang and clangd. Maybe I could add some tests for CUDA,
OpenMP if needed.
WDYT
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
oToToT added a comment.
ping!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98128/new/
https://reviews.llvm.org/D98128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
oToToT added a comment.
Kindly ping.
Maybe I should add a test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98128/new/
https://reviews.llvm.org/D98128
___
cfe-commits mailing list
cfe-commits@lists.ll
oToToT updated this revision to Diff 328814.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98128/new/
https://reviews.llvm.org/D98128
Files:
clang-tools-extra/clangd/Compiler.cpp
clang/lib/Frontend/ASTUnit.cpp
clang/lib/Frontend/PrecompiledPre
oToToT created this revision.
oToToT added reviewers: sammccall, rsmith, ilya-biryukov.
oToToT added projects: clang, clang-tools-extra.
Herald added subscribers: usaxena95, kadircet, arphaman.
oToToT requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay.
Heral
