[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa89ac0dd185d: Update __is_unsigned builtin to match the Standard. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver updated this revision to Diff 329761. zoecarver added a comment. - Fix review comments: add colon, reflow line, and fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98104/new/ https://reviews.llvm.org/D98104 Files: clang/docs/La

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver added a comment. Sorry for the delay in updating. All review comments have been addressed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98104/new/ https://reviews.llvm.org/D98104 ___

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

rsmith added a comment. LGTM too, once the remaining pending comments are addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98104/new/ https://reviews.llvm.org/D98104 ___ cfe-commits mailing list

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1207 * ``__is_union`` (C++, GNU, Microsoft, Embarcadero) * ``__is_unsigned`` (C++, Embarcadero) + Returns false for enumeration types. Note, before Clang 13, returned true for Please a

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

Quuxplusone added a comment. LGTM now, mod the (important!) typo in the test. Comment at: clang/test/SemaCXX/type-traits.cpp:1444 int t27[F(__is_signed(UnionAr))]; + int t28[F(__is_unsigned(UnsignedEnum))]; } s/is_unsigned/is_signed/ Repository: rG LLV

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver updated this revision to Diff 328905. zoecarver added a comment. - Address Arthur's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98104/new/ https://reviews.llvm.org/D98104 Files: clang/docs/LanguageExtensions.rst clang/lib

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4837 +// Enum types should always return false (same as UTT_IsSigned). +return !T->isEnumeralType() && T->isUnsignedIntegerType(); Quuxplusone wrote: > FWIW, I'd lose the parent

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

Quuxplusone added a comment. 🎉 Comment at: clang/lib/Sema/SemaExprCXX.cpp:4837 +// Enum types should always return false (same as UTT_IsSigned). +return !T->isEnumeralType() && T->isUnsignedIntegerType(); FWIW, I'd lose the parenthetical comment, and

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1199 + types. Note, before Clang 10, returned true for enumeration types if the + underlying type was signed, and returned false for floating-point types. * ``__is_standard_layout`` (C++, GNU, Micro

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver created this revision. zoecarver added reviewers: ldionne, rsmith, tmatheson. zoecarver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updates __is_unsigned to have the same behavior as the standard specifies. This is in line wit