[PATCH] D98030: [IR] Add vscale_range IR function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48f5a392cb73: [IR] Add vscale_range IR function attribute (authored by bsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith updated this revision to Diff 330691. bsmith marked 3 inline comments as done. bsmith added a comment. - Prevent vscale_range(0,0) from crashing and instead don't add the attribute - Improve CHECK lines in arm-sve-vector-bits-vscale-range.c test - Test vscale_range(0,0) case and move some t

[PATCH] D98030: [IR] Add vscale_range IR function attribute

paulwalker-arm added inline comments. Comment at: clang/test/CodeGen/arm-sve-vector-bits-vscale-range.c:10-14 +// CHECK-128: attributes #0 = { {{.*}} vscale_range(1,1) {{.*}} } +// CHECK-256: attributes #0 = { {{.*}} vscale_range(2,2) {{.*}} } +// CHECK-512: attributes #0 = { {{.

[PATCH] D98030: [IR] Add vscale_range IR function attribute

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Looks fine to me, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98030/new/ https://reviews.llvm.org/D98030 __

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:570 +Result += utostr(MinValue); +Result += ','; +Result += utostr(MaxValue); peterwaller-arm wrote: > Nit: The only other precedent I can see for this is `allocsize`. Grepping the

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith updated this revision to Diff 330205. bsmith marked 3 inline comments as done. bsmith added a comment. - State what lack of vscale_range attribute means in LangRef - Minor formatting change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98030/

[PATCH] D98030: [IR] Add vscale_range IR function attribute

peterwaller-arm added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:570 +Result += utostr(MinValue); +Result += ','; +Result += utostr(MaxValue); Nit: The only other precedent I can see for this is `allocsize`. Grepping the code I found thi

[PATCH] D98030: [IR] Add vscale_range IR function attribute

paulwalker-arm added inline comments. Comment at: llvm/docs/LangRef.rst:1998 +function. A value of 0 means unbounded. If the optional max value is omitted +then max is set to the value of min. sdesmalen wrote: > Do you need to say anything about a defa

[PATCH] D98030: [IR] Add vscale_range IR function attribute

sdesmalen added a comment. Thanks for this patch, it's great to have an IR attribute for this. The mechanics of this patch look mostly fine to me. I added a few more subscribers to give this some wider visibility. Comment at: llvm/docs/LangRef.rst:1998 +function. A value o

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith created this revision. bsmith added reviewers: paulwalker-arm, joechrisellis, peterwaller-arm. Herald added subscribers: dexonsmith, jdoerfert, steven_wu, hiraditya. bsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-comm