This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4f1bbc0b8426: [clangd] Introduce a CommandLineConfigProvider
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:555
+};
+if (Sync) {
+ IndexLoadTask();
sammccall wrote:
> (This seems a little weird, get passed in a task runner and maybe ignore it.
> Seems like the asyncpr
kadircet updated this revision to Diff 328485.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98029/new/
https://reviews.llvm.org/D98029
Files:
clang-tools-ex
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Both side-effects seem fine to me.
> EnableBackgroundIndex option controls whether the component will be created
> at all
Do you think we should eventually switch to always setting
Cla
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This enables unifying command line flags wi
