[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

MaskRay added a comment. In D98022#2609597 , @mstorsjo wrote: > In D98022#2609380 , @MaskRay wrote: > >> The test should be fixable with explicit `--unwindlib=platform`. > > Sure, but this change also was meant to b

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

mstorsjo added a comment. In D98022#2609380 , @MaskRay wrote: > The test should be fixable with explicit `--unwindlib=platform`. Sure, but this change also was meant to be a NFC, which it wasn't... so either we make this case set the unwindlib to `""`, o

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

MaskRay added a comment. The test should be fixable with explicit `--unwindlib=platform`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98022/new/ https://reviews.llvm.org/D98022 ___ cfe-commits mailing

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

mstorsjo added a comment. In D98022#2609374 , @phosek wrote: > We use `CLANG_DEFAULT_RTLIB=compiler-rt` for our toolchain and it looks like > after this change, two tests started failing: > [...] > This is presumably because both of these tests assume tha

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

phosek added a comment. We use `CLANG_DEFAULT_RTLIB=compiler-rt` for our toolchain and it looks like after this change, two tests started failing: TEST 'Clang :: Driver/compiler-rt-unwind.c' FAILED /b/s/w/ir/x/w/llvm-project/clang/test/Driver/com

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002dd47bdd67: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98022/new/ https://reviews.llvm.org/D98022

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

mstorsjo created this revision. mstorsjo added reviewers: saugustine, MaskRay, phosek. Herald added a subscriber: mgorny. mstorsjo requested review of this revision. Herald added a project: clang. CLANG_DEFAULT_RTLIB had a typo, and libunwind isn't a valid option for it. This keeps the practical