[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

2021-03-05 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa60d06d8b757: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

2021-03-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97950/new/ https://reviews.llvm.org/D97950

[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

2021-03-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I know we talked about names a bunch and i'm being a bit intransigent here. Happy to go with Component if you think it's a better name, but wanted to see how this looks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97950

[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

2021-03-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. As pointed out in D96244