This revision was automatically updated to reflect the committed changes.
Closed by commit rG13c77f204671: [OpenCL] Fix builtins that require multiple
extensions (authored by svenvh).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97930/new/
https://
Anastasia added a comment.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97930/new/
https://reviews.llvm.org/D97930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks.
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:188
+ // expected-error@-2{{no matching function for call to 'write_imagef'}}
+ // expecte
svenvh updated this revision to Diff 328549.
svenvh added a comment.
> You don't seem to be using write_imagef for OpenCL versions <= 1.2. But
> should we be checking that the diagnostic is given?
Good point, I have updated the test to check for the diagnostic.
CHANGES SINCE LAST ACTION
http
Anastasia added inline comments.
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:21
+#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2
+#pragma OPENCL EXTENSION cl_khr_3d_image_writes : enable
+#endif
You don't seem to be using `write_imagef` for OpenCL ve
svenvh created this revision.
svenvh added a reviewer: Anastasia.
svenvh added a project: clang.
Herald added a subscriber: yaxunl.
svenvh requested review of this revision.
Herald added a subscriber: cfe-commits.
Builtins that require multiple extensions, such as certain
`write_imagef` forms, wer
