[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfd301ec8b5: [SystemZ] Test for isinf and isfinite in testFPKind(). (authored by jonpa). Herald added a project: clang. Repository: rG LLVM Githu

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97901/new/ https://reviews.llvm.org/D97901 ___ cfe-commits mailing list cf

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa updated this revision to Diff 330753. jonpa added a comment. > This "invert" logic doesn't look correct. "isfinite" and "isinf" both need to > return false on NaNs. I think you should just drop the invert logic and use a > TDC mask of 0xFC0 (zero, normal, or subnormal) to implement "isfini

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; thopre wrote: > uweigand wrote: > > thopre wrote: > > > jonpa wrote: > > > > What are the

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; uweigand wrote: > thopre wrote: > > jonpa wrote: > > > What are these variants all about.

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

uweigand added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; thopre wrote: > jonpa wrote: > > What are these variants all about...? > > > They were

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; jonpa wrote: > What are these variants all about...? > They were introduced in https://r

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; What are these variants all about...? CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa created this revision. jonpa added reviewers: uweigand, thopre. jonpa requested review of this revision. Recognize __builtin_isinf and BI__builtin_isfinite (and a few other builtin opcodes for finite checks) in testFPKind(). TDC can check for infinity, and for finite with an inversion of t