[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

2021-03-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); --

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

2021-03-04 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); ---

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

2021-03-04 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); ---

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

2021-03-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); --

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

2021-03-03 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: usaxena95, kadircet, xazax.hun. njames93 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. I'm unable to figure out a reproducti