[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a2a167b6ca7: [DirectoryWatcher] Increase timeout to make test less flaky (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ ht

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai added a comment. In D97878#2602077 , @plotfi wrote: > This makes sense to me. I approve. Can we move the 3/60 seconds number to a > const int value set somewhere higher up in the file as a global with a > comment explaining this as well? Updated

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai updated this revision to Diff 328283. smeenai added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 Files: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

jkorous added a comment. LGTM. Adding the comment would be great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

plotfi added a comment. @jkorous thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

plotfi accepted this revision. plotfi added a comment. This revision is now accepted and ready to land. This makes sense to me. I approve. Can we move the 3/60 seconds number to a const int value set somewhere higher up in the file as a global with a comment explaining this as well? Repository

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai created this revision. smeenai added reviewers: jkorous, arphaman, akyrtzi, gribozavr. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've observed this test being significantly flaky on our Mac CI machines when we're runn