[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

2022-11-30 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. This looks very interesting. I had a discussion with someone at the recent LLVM Dev Meeting about the possibility of something like this. However, rather than tracking error based on data precision, I am interested in tracking errors introduced by fast-math base

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

2022-11-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. This looks very interesting and I wish that I can help as well (but I'll likely spend very little time in December due to holidays:) ). Hmm, I can't find it in an email archive. Perhaps there hasn't been a discussion so people are unaware of this work... Repository:

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

2022-11-22 Thread Clement Courbet via Phabricator via cfe-commits
courbet added a subscriber: titeup. courbet added a comment. In D97854#3944804 , @olologin wrote: > @courbet > Hi, sorry for pinging you. > Is this review stalled? Is there a reason for this? Judging by paper this > sanitizer looks promising. I was recen

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

2022-11-22 Thread Ibraim Ganiev via Phabricator via cfe-commits
olologin added a comment. @courbet Hi, sorry for pinging you. Is this review stalled? Judging by paper this sanitizer looks promising. I was recently planning to try out NSAN on huge codebase. Is there anything wrong with this review? Just curious. Maybe I could help with something but I doubt

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

2021-03-10 Thread Clement Courbet via Phabricator via cfe-commits
courbet added a comment. In D97854#2617097 , @scanon wrote: > Is there a mechanism to instruct the sanitizer to ignore a specific > expression or function? From a cursory reading, I am mildly concerned about a > deluge of false positives from primitives

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

2021-03-10 Thread Steve Canon via Phabricator via cfe-commits
scanon added a comment. Is there a mechanism to instruct the sanitizer to ignore a specific expression or function? From a cursory reading, I am mildly concerned about a deluge of false positives from primitives that compute exact (or approximate) residuals; these are acting to eliminate or pre

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

2021-03-03 Thread Clement Courbet via Phabricator via cfe-commits
courbet added a comment. When bootstrapping LLVM with nsan, there are only a few issues. Several of them stem from using `double` to measure elapsed time in seconds: We measure start time, end time, and subtract them. The resulting error depends on the arbitrary magnitude of the time since epoc