[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327825. stevewan added a comment. Reflect varible is unused in its name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Driver/ToolChains/CommonArg

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); stevewan wrote: > jsji wrote: > > `micro`

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); jsji wrote: > `micro` unsed. Sorry I missed this comment. I agree t

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327803. stevewan added a comment. Improve handling different AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Driver/ToolChains/CommonA

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327798. stevewan added a comment. Address comments with regard to handling older AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Drive

[PATCH] D97823: Update default arch on AIX

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); `micro` unsed. Comment at: clang/lib/Driver/ToolChai

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji wro

[PATCH] D97823: Update default arch on AIX

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji wrote:

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pw

[PATCH] D97823: Update default arch on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, the default arch level should match the minimum supported arch level of the OS version Repository: rG LLVM Github Monorepo https://review