[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08c04ca00542: [clangd] Overload bundles are only deprecated if each overloads is. (authored by sammccall). Changed prior to commit: https://review

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:410 +if (Completion.Deprecated) { + Completion.Deprecated = + (C.SemaResult && kbobyrev wrote: > sammccall wrote: > > kbobyrev wrote: > > > The comment you ad

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. I see, thank you very much for the explanation! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:410 +if (Completion.Deprecated) { + Completion.Deprecated =

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall added a comment. Herald added a project: clang-tools-extra. Whoops, lost this patch... In D97803#2602787 , @kbobyrev wrote: > So, if my understanding is correct, this will make the whole bundle > non-deprecated if at least one overload is not d

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

kbobyrev added a comment. So, if my understanding is correct, this will make the whole bundle non-deprecated if at least one overload is not deprecated? This is probably an improvement over the existing behaviour. However, do we maybe want to split the bundles into deprecated and non-deprecated

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall updated this revision to Diff 327574. sammccall added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97803/new/ https://reviews.llvm.org/D97803 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/cla

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall updated this revision to Diff 327565. sammccall edited the summary of this revision. sammccall added a comment. fix bug link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97803/new/ https://reviews.llvm.org/D97803 Files: clang-tools-ex

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd