[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

2021-03-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG188373fb4697: [clangd] Make WorkspaceSymbols request work with empty queries (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97773/new/

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

2021-03-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM OK, I think we've established that the request was for a way to dump out clangd's whole index, and workspace/symbol isn't actually a good way to do that. Nevertheless, this seems us

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

2021-03-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I've asked on the bug for some more context for the request. I don't see a problem with this change per se but I'm not sure it'll actually fix the bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97773/new/ https://rev

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

2021-03-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd uses codecompletion limit as the limit