[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

2021-03-03 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG584cb67d2df3: [IRSymTab] Set FB_used on llvm.compiler.used symbols (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D97755

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

2021-03-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 327958. MaskRay edited the summary of this revision. MaskRay added a comment. Add llvm-nm checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97755/new/ https://reviews.llvm.org/D97755 Files: clang/test/Cod

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

2021-03-03 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with change suggested below. Thanks! Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10 + +//--- a.c +const char *ref() { MaskRay wrote: > te

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

2021-03-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10 + +//--- a.c +const char *ref() { tejohnson wrote: > Is this other file needed for the test? This is test the limitation. If we fix the tracking for inline asm references (thi

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

2021-03-03 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10 + +//--- a.c +const char *ref() { Is this other file needed for the test? Comment at: llvm/test/ThinLTO/X86/asm.ll:11 +; NM-NOT: {{.}} +; NM: -

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

2021-03-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 327909. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a clang/test/CodeGen/ test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97755/new/ https://reviews.ll